Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some streams disappear when clicking subspace stream #2719

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Some streams disappear when clicking subspace stream #2719

merged 5 commits into from
Aug 27, 2024

Conversation

MeyerPV
Copy link
Collaborator

@MeyerPV MeyerPV commented Aug 1, 2024

https://daostack.notion.site/Some-streams-disappear-when-clicking-subspace-stream-1770dddc787d414c8c54aa9e87bc7cce

What was changed?

  • Optimized FeedItem component
  • Fixed condition in FeedLayout

@MeyerPV MeyerPV requested a review from elatif2020 August 1, 2024 16:09
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 7bc0954
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/66cc857a7f6d1f0008ff8873
😎 Deploy Preview https://deploy-preview-2719--preview-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elatif2020
Copy link
Collaborator

elatif2020 commented Aug 5, 2024 •
edited
Loading

@MeyerPV
I have a crash here (which doesn't happen in dev)
see the screen recording https://us02web.zoom.us/clips/share/0LSz7hQ3mzOuzeS9aqdM7qfdbdz2s1xe7liJkc7BQ6CRmfsLb72zLWwmxYMnHp5TTA3_L0yvxWKBC_Dz338i1mx2.SpRHrUIGU_sUrH7F

@elatif2020
Copy link
Collaborator

@MeyerPV
see the recording here
I run it in codespace to get the console error details

@elatif2020
Copy link
Collaborator

@MeyerPV The original issue reproduced for me when clicking some items in a grandchild space. It doesn't happen for every such item. See the the screen recording here

@MeyerPV MeyerPV mentioned this pull request Aug 16, 2024
Closed
@MeyerPV MeyerPV merged commit c4a2fb7 into dev Aug 27, 2024
5 checks passed
@MeyerPV MeyerPV deleted the CW-some-stream-disappear branch August 27, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elatif2020 elatif2020 elatif2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeyerPV @elatif2020